Encode complex types in section mangling #1199
Conversation
CohenArthur
force-pushed
the
encode-complex-types
branch
from
15e599b
to
103a3e1
Compare
CohenArthur
force-pushed
the
encode-complex-types
branch
2 times, most recently
from
0c26c1c
to
be78df6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
==========================================
- Coverage 95.62% 91.11% -4.51%
==========================================
Files 150 153 +3
Lines 42657 44816 +2159
==========================================
+ Hits 40789 40833 +44
- Misses 1868 3983 +2115 ☔ View full report in Codecov by Sentry. |
| // the same. Therefore, only encode it as its underlying type. | ||
| DataTypeInformation::SubRange { referenced_type, .. } => access_inner(referenced_type)?, | ||
| DataTypeInformation::Generic { .. } | DataTypeInformation::Alias { .. } => { | ||
| // FIXME: Is that correct? |
There was a problem hiding this comment.
Yes, generics and aliases will be resolved to the correct types during the resolve phase.
| DataTypeInformation::Array { inner_type_name, .. } => { | ||
| Type::Array { inner: Box::new(access_inner(inner_type_name)?) } | ||
| } | ||
| // FIXME: Is that correct? |
There was a problem hiding this comment.
Yes, the range is only relevant at compile time AFAIK.
Technically the norm allows for different runtime behaviour if a value is out of range, but this would still not affect the generated type, only some functions that the user needs to have.
The subrange has an implicit method that gives the upper and lower bounds but this is resolved on compile time as well since the range is known.
CohenArthur
force-pushed
the
encode-complex-types
branch
from
be78df6
to
a975ea3
Compare
CohenArthur
force-pushed
the
encode-complex-types
branch
from
a975ea3
to
54e08eb
Compare
|
@ghaith rebased properly, sorry for the confusion :) |
Needs #1198
This PR allows the section mangler to encode more type information in order to specify structs, enumerations, arrays and aliases. There are still some missing bits, e.g. regarding the length of arrays